Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust fields as argument textobject #9637

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

uek-1
Copy link
Contributor

@uek-1 uek-1 commented Feb 15, 2024

Added struct field declarations and initializations as argument textobjects. Should allow ]a to highlight fields in structs. Closes #9155. Let me know if I messed anything up, this is my first real commit to an open source project.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see field_initializer_list roughly fitting into the argument/parameter textobject but field_declaration_list should be removed

@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Feb 15, 2024
@the-mikedavis the-mikedavis changed the title [Rust] Added fields as argument textobject (#9155) Add Rust fields as argument textobject Feb 15, 2024
@uek-1
Copy link
Contributor Author

uek-1 commented Feb 16, 2024

I removed field_declaration_list .

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 17, 2024
@pascalkuthe pascalkuthe merged commit 3e963b3 into helix-editor:master Feb 17, 2024
6 checks passed
uek-1 added a commit to uek-1/helix that referenced this pull request Feb 24, 2024
* added field_declaration_list and field_initializer_list as parameter textobjects

* removed field_declaration_listt from textobjects.scm
cosmikwolf pushed a commit to cosmikwolf/helix that referenced this pull request Feb 26, 2024
* added field_declaration_list and field_initializer_list as parameter textobjects

* removed field_declaration_listt from textobjects.scm
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* added field_declaration_list and field_initializer_list as parameter textobjects

* removed field_declaration_listt from textobjects.scm
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* added field_declaration_list and field_initializer_list as parameter textobjects

* removed field_declaration_listt from textobjects.scm
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* added field_declaration_list and field_initializer_list as parameter textobjects

* removed field_declaration_listt from textobjects.scm
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* added field_declaration_list and field_initializer_list as parameter textobjects

* removed field_declaration_listt from textobjects.scm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rust] tag fields as argument textobjects
3 participants